This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Update TVU drawing with shred verification parts #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
update-tvu-drawing
branch
from
41c23fb to
7b24db6
Compare
sakridge
changed the title
sakridge
force-pushed
the
update-tvu-drawing
branch
from
7b24db6 to
2cb26fb
Compare
aeyakovenko
previously approved these changes
Mar 4, 2020
garious
previously approved these changes
Mar 4, 2020
|
arrows too. You can render it, by typing |
sakridge
force-pushed
the
update-tvu-drawing
branch
from
2cb26fb to
39e2619
Compare
mergify
bot
dismissed stale reviews from aeyakovenko and garious
Pull request has been modified.
I found some GUI editors that make creating the diagram much easier like http://asciiflow.com/ and https://textik.com/#fe7c7cbe34b50c2b, but they both use the Do you know of anything similar which has the other corner style?
I added the arrows. |
|
I don't know of a GUI. That's a strong argument for hard edges. Happy to support the subset that makes updates as easy as possible. |
garious
previously approved these changes
Mar 4, 2020
sakridge
force-pushed
the
update-tvu-drawing
branch
from
39e2619 to
ea4d2dc
Compare
sakridge
force-pushed
the
update-tvu-drawing
branch
2 times, most recently
from
eabc790 to
8d2fac5
Compare
sakridge
force-pushed
the
update-tvu-drawing
branch
from
8d2fac5 to
ab410b8
Compare
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TVU drawing is missing some blocks.
Summary of Changes
Add shred sigverify stage, blockstore, and Poh verify, transaction sig verify blocks.