This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
catchup now supports an optional RPC URL argument for validators with private RPC…
#8629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8629 +/- ##
========================================
- Coverage 80% 80% -0.1%
========================================
Files 258 258
Lines 55847 55858 +11
========================================
- Hits 44719 44718 -1
- Misses 11128 11140 +12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana catchupuses gossip to locate the RPC port of the validator of interest.However validators using the
--private-rpcflag will not publish an RPC port in gossip, and thussolana catchupcan't find them. But now this is possible by optionally supplying the RPC URL.For example, a validator that uses
--rpc-bind-address 127.0.0.1from #8628 can runto monitor the catchup of their node. Of course this only works if the
solana catchupcommand is run from the same machine.Fixes #8407