plug in LedgerWindow #879
Merged
plug in LedgerWindow #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
force-pushed
the
ra-window
branch
2 times, most recently
from
3ce5016 to
64ae794
Compare
|
the depths to which I had to plumb options and &mut Option<&mut LedgerWindow> makes me think there's a better way |
|
the large network test takes longer to converge and does so less often. I think this is because a disk seek and read in the gossip pipeline is hurting us. I think repair requests from disk may need their own stage/thread, whatever. |
garious
reviewed
Aug 7, 2018
| @@ -954,6 +955,7 @@ impl Crdt { | |||
| } | |||
| fn run_window_request( | |||
| window: &SharedWindow, | |||
| ledger_window: &mut Option<&mut LedgerWindow>, | |||
There was a problem hiding this comment.
it was the only way I could figure out how to get the ledgerwindow through a Builder(|move| and a loop
There was a problem hiding this comment.
if you're on the Rust server, you can look up my question in #beginners
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Apr 18, 2024
…gram_accounts()` (solana-labs#879) Removes the owner form the result of filter_executable_program_accounts(). Updates the description of the function.
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
…able_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb.
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
…able_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb.
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
* Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (solana-labs#768)" This reverts commit e7617a1.
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
…able_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb.
KirillLykov
pushed a commit
to KirillLykov/solana
that referenced
this pull request
Nov 8, 2024
* Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (solana-labs#768)" This reverts commit e7617a1.
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Nov 26, 2024
…a-labs#3521) (solana-labs#3544) Revert - solana-labs#879 and solana-labs#768 (solana-labs#3521) * Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (solana-labs#768)" This reverts commit e7617a1. (cherry picked from commit 57bdb8e) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.