-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partition setup #9386
Merged
Merged
Fix partition setup #9386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
previously approved these changes
Apr 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #9386 +/- ##
========================================
- Coverage 81.1% 81.1% -0.1%
========================================
Files 276 276
Lines 62110 62110
========================================
- Hits 50429 50427 -2
- Misses 11681 11683 +2 |
mergify
bot
dismissed
aeyakovenko’s stale review
April 9, 2020 07:02
Pull request has been modified.
carllin
added
v1.1
automerge
Merge this Pull Request automatically once CI passes
labels
Apr 9, 2020
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2020
automerge (cherry picked from commit 21cb56d)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 9, 2020
carllin
pushed a commit
to carllin/solana
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tc
on ingress traffic.Summary of Changes
ifb0
. This allows ingress traffic to then be shaped using stateful qdiscs and filters, allowing for originally intended behavior of dropping incoming packets based ontos
field.On a 4 node network, 50-50 split, 2-min partition:
Partitions actually seem to be happening in gossip now!
Both validators on the of the the bootstrap leader continue to move during partition (76% of the stake):
Validators on other side get stuck as expected (24% of the stake):
Fixes #