Tame wallet manager better #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 18, 2020 11:27
CriesofCarrots
force-pushed
the
tame-wallet-manager-better
branch
from
735780c to
1ea8925
Compare
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #9567 +/- ##
========================================
- Coverage 80.6% 80.5% -0.1%
========================================
Files 279 279
Lines 63414 63410 -4
========================================
- Hits 51112 51089 -23
- Misses 12302 12321 +19 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2020
automerge (cherry picked from commit 679e786)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 18, 2020
|
Bizarre type. Why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#9262 and #9555 weren't quite the right approach, due to the default keypair; wallet manager should only be initialized when a signer is actually needed from a remote wallet, not any time config is set to a remote wallet url.
Summary of Changes
&mut, and only initialize/read_devices when needed and not already done.