Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Add winner tool #12

Merged
merged 20 commits into from
Oct 14, 2019
Merged

Add winner tool #12

merged 20 commits into from
Oct 14, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Oct 2, 2019

Problem

Need transparent deterministic tooling for determining the winners of TdS

Summary of Changes

Reference

https://forums.solana.com/t/tour-de-sol-stage-1-preliminary-compensation-design/79

Fixes solana-labs/solana#6076

@jstarry jstarry changed the title Add prize tool WIP: Add prize tool Oct 3, 2019
@jstarry jstarry changed the title WIP: Add prize tool Add prize tool Oct 4, 2019
@jstarry
Copy link
Member Author

jstarry commented Oct 4, 2019

@mvines I've written the tool to output the winners (top 3 + percentile buckets), but it might just be simpler to have it write a couple CSVs with an ordered list of results for each category. Thoughts?

.travis.yml Show resolved Hide resolved
prize-tool/Cargo.toml Outdated Show resolved Hide resolved
prize-tool/Cargo.toml Outdated Show resolved Hide resolved
prize-tool/src/main.rs Outdated Show resolved Hide resolved
prize-tool/src/main.rs Outdated Show resolved Hide resolved
prize-tool/src/utils.rs Outdated Show resolved Hide resolved
prize-tool/src/prize.rs Outdated Show resolved Hide resolved
prize-tool/src/main.rs Outdated Show resolved Hide resolved
prize-tool/src/main.rs Outdated Show resolved Hide resolved
prize-tool/src/main.rs Outdated Show resolved Hide resolved
prize-tool/src/availability.rs Outdated Show resolved Hide resolved
prize-tool/src/availability.rs Outdated Show resolved Hide resolved
prize-tool/src/utils.rs Outdated Show resolved Hide resolved
prize-tool/src/availability.rs Outdated Show resolved Hide resolved
prize-tool/src/confirmation_latency.rs Outdated Show resolved Hide resolved
@jstarry
Copy link
Member Author

jstarry commented Oct 11, 2019

Addressed feedback but have been investigating why my recent tests have not been seeing the expected number of vote and stake accounts from the bank. Will fix tests following that investigation! Fixed

EDIT: the reason was because I was testing the tool after cargo installing it and that doesn't work because the blocktree processor doesn't have the right paths to load the native programs 🤦‍♂

@jstarry jstarry changed the title Add prize tool Add winner tool Oct 12, 2019
@jstarry
Copy link
Member Author

jstarry commented Oct 14, 2019

@CriesofCarrots @mvines I've addressed feedback, added more tests, and verified the tool against a local cluster. Please take another look when you have time!

@@ -0,0 +1,179 @@
//! This tool calculates the quantitative category winners for Tour de SOL.
//!
//! NOTE: Ledger processing uses native programs, so this tool must be invoked with `cargo run`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this info, and other general operating instructions into a new section of https://github.com/solana-labs/tour-de-sol/blob/master/README-internal.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and one better (fine as a follow-up PR if that's easier): a new shell script like https://github.com/solana-labs/tour-de-sol/blob/master/bench-tps.sh that runs the tool with all the right settings against the actual TdS cluster.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call #13

Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. This PR is starting to get pretty hard to review due to it's size, time to just land it and use follow-up PRs IMO

@jstarry jstarry merged commit 3c9ecf1 into solana-labs:master Oct 14, 2019
@jstarry jstarry deleted the prize-tool branch October 14, 2019 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants