-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
@mvines I've written the tool to output the winners (top 3 + percentile buckets), but it might just be simpler to have it write a couple CSVs with an ordered list of results for each category. Thoughts? |
Addressed feedback but have been investigating why my recent tests have not been seeing the expected number of vote and stake accounts from the bank. EDIT: the reason was because I was testing the tool after |
@CriesofCarrots @mvines I've addressed feedback, added more tests, and verified the tool against a local cluster. Please take another look when you have time! |
@@ -0,0 +1,179 @@ | |||
//! This tool calculates the quantitative category winners for Tour de SOL. | |||
//! | |||
//! NOTE: Ledger processing uses native programs, so this tool must be invoked with `cargo run`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this info, and other general operating instructions into a new section of https://github.com/solana-labs/tour-de-sol/blob/master/README-internal.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and one better (fine as a follow-up PR if that's easier): a new shell script like https://github.com/solana-labs/tour-de-sol/blob/master/bench-tps.sh that runs the tool with all the right settings against the actual TdS cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call #13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. This PR is starting to get pretty hard to review due to it's size, time to just land it and use follow-up PRs IMO
Problem
Need transparent deterministic tooling for determining the winners of TdS
Summary of Changes
Reference
https://forums.solana.com/t/tour-de-sol-stage-1-preliminary-compensation-design/79
Fixes solana-labs/solana#6076