Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external accounts #54

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Add support for external accounts #54

merged 8 commits into from
Jun 13, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Jun 5, 2024

This PR adds support for loading external accounts as dependencies. These are specified on Cargo.toml as a list of addresses under a account-dependencies property – e.g.,:

[package.metadata.solana]
program-id = "11111111111111111111111111111111"
account-dependencies = ["SysvarC1ock11111111111111111111111111111111"]

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: d81e2d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-program Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@febo febo requested a review from lorisleiva June 5, 2024 20:46
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for that Febo! Just a couple of small comments but it looks good to me.

template/base/scripts/program/dump.mjs Outdated Show resolved Hide resolved
template/base/scripts/program/dump.mjs Outdated Show resolved Hide resolved
template/base/scripts/program/dump.mjs Outdated Show resolved Hide resolved
@febo febo marked this pull request as ready for review June 9, 2024 22:57
@febo febo requested a review from lorisleiva June 9, 2024 22:57
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Febo! 👌

@febo febo merged commit 99ef740 into main Jun 13, 2024
6 checks passed
@febo febo deleted the febo/external-accounts branch June 13, 2024 06:48
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants