Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command-line args parsing on scripts #56

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

febo
Copy link
Contributor

@febo febo commented Jun 13, 2024

This PR fixes the command-line parsing so all arguments are passed to the target command.

The current version of the scripts passes the arguments under argv._, which is only a subset of the arguments.

Arguments are taken directly from process.argv with the change in this PR.

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 10a3345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-program Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@febo febo requested a review from buffalojoec June 13, 2024 20:20
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. The CI error looks unrelated.

@lorisleiva
Copy link
Member

I wonder why this warning suddenly became an error here.

@febo febo merged commit 36269ed into main Jun 14, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
@febo febo deleted the febo/fix-args-parsing branch June 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants