Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect installed Rust version #71

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Detect installed Rust version #71

merged 6 commits into from
Jul 23, 2024

Conversation

lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Jul 23, 2024

This PR changes the way we decide on the toolchain to use by resolving the Rust version first by:

  • Accepting a manual override using a --rust CLI option
  • Detecting the Rust version installed using rustc --version
  • Fallbacking to a Rust version that's compatible with the detected Solana version.

This PR also logs a warning if the resolved Rust version and the resolved Solana version could have compatibility issues.

This PR also does a bunch of refactoring, especially in version manipulation.

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: e956866

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-program Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva changed the title Detect install Rust version Detect installed Rust version Jul 23, 2024
@lorisleiva lorisleiva self-assigned this Jul 23, 2024
@lorisleiva lorisleiva marked this pull request as ready for review July 23, 2024 14:34
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lorisleiva lorisleiva merged commit 4a55c62 into main Jul 23, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants