Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface scripts #17

Merged
merged 24 commits into from
Nov 11, 2024
Merged

Add interface scripts #17

merged 24 commits into from
Nov 11, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Oct 23, 2024

This PR adds scripts and workflow steps for the interface crate.

@febo febo marked this pull request as ready for review October 23, 2024 16:24
buffalojoec
buffalojoec reviewed Oct 24, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
interface/src/error.rs Outdated Show resolved Hide resolved
scripts/interface/lint.mjs Outdated Show resolved Hide resolved
joncinque
joncinque reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of little things

scripts/interface/lint.mjs Outdated Show resolved Hide resolved
scripts/interface/test.mjs Outdated Show resolved Hide resolved
@febo febo requested a review from joncinque October 31, 2024 23:28
joncinque
joncinque approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

lorisleiva
lorisleiva approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the setup/action.yml changes. Thanks!

@febo febo force-pushed the febo/system-instruction branch 2 times, most recently from fdc4fe8 to 0e76174 Compare November 7, 2024 21:22
@febo febo mentioned this pull request Nov 8, 2024
Merged
@febo febo force-pushed the febo/interface-scripts branch from 2be1050 to e80d222 Compare November 8, 2024 13:39
Base automatically changed from febo/system-instruction to main November 11, 2024 17:08
@febo febo force-pushed the febo/interface-scripts branch from ce5fb72 to 66195e6 Compare November 11, 2024 21:00
@febo febo merged commit 53e4667 into main Nov 11, 2024
7 checks passed
@febo febo deleted the febo/interface-scripts branch November 11, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

@buffalojoec buffalojoec buffalojoec approved these changes

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@febo @joncinque @lorisleiva @buffalojoec