Multisig support on invoke helpers #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
commented
Feb 26, 2025
| mint_info.key, | ||
| destination_info.key, | ||
| authority_info.key, | ||
| &[], // add them later, to avoid unnecessary clones |
There was a problem hiding this comment.
The source of the bug. Signer status is added depending if the accounts are added here. See:
token-2022/program/src/instruction.rs
Lines 1689 to 1692 in d52d1cd
grod220
force-pushed
the
invoke-transfer-bug-fix
branch
from
1e0c162 to
5f0af83
Compare
grod220
requested review from
joncinque and
buffalojoec
and removed request for
joncinque and
buffalojoec
|
Talked to @buffalojoec offline about stubbing the sys calls versus the manual dependency injection pattern. Will re-request when ready 👍 |
grod220
force-pushed
the
invoke-transfer-bug-fix
branch
from
5f0af83 to
4b8d38b
Compare
grod220
commented
Feb 27, 2025
grod220
force-pushed
the
invoke-transfer-bug-fix
branch
from
1fedcbb to
44d9478
Compare
buffalojoec
reviewed
Feb 28, 2025
buffalojoec
approved these changes
Feb 28, 2025
program/src/onchain.rs
Outdated
Comment on lines
630
to
647
| #[test] | ||
| fn test_single_signer() { | ||
| test_parameterized_invoke_fns(false, false, false); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_single_signer_with_fee() { | ||
| test_parameterized_invoke_fns(false, true, false); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_single_signer_with_transfer_hook() { | ||
| test_parameterized_invoke_fns(false, false, true); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_single_signer_with_fee_and_transfer_hook() { | ||
| test_parameterized_invoke_fns(false, true, true); |
There was a problem hiding this comment.
You should consider test_case!
|
Sorry for the late review, but this looks good! I've been working on using the split-up crates in token-2022, which unfortunately means that we can't use the program stubs, so I refactored the code a little bit to make it testable without the program stubs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Bug fix ==
At the moment, these helpers are passing in an empty signers slice to
transfer_checked()andtransfer_checked_with_fee()to avoid clones. Unfortunately, for multisigs, this improperly adds signer status to theauthority_infowhich causes an permissions escalation error for consumers.This PR does:
_invoke_transfer_internal()to reduce redundancy between functions & allow dependency injection