Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1205

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Conversation

Metritutus
Copy link
Collaborator

  • Updated buildCarrier() method in StarUpgradeService to validate that the carrier is being built with a whole number of ships.
  • Removed ownedByPlayer property from MapObject. Replaced with dynamic value resolution in the client for the tables that used this property for sorting.
  • Added the ability to end user impersonation.
  • Added new sessionService.
  • Updated SessionData interface to include other properties that are already being used in uses of SessionData.
  • Updated numerous areas that would adjust data that was also stored in user sessions to also update that user's sessions so that the data is aligned.
  • Updated listUsers() method in AdminService to query the database for the user's roles rather than using their session data.
  • Updated setCredits() method in UserService to return the amount of credits set.
  • Updated Users component:
    • Updated to show/hide certain settings based on the user's roles.
    • Updated to update the current administrator user's credits/roles in their local session if they are adjusting themselves.
    • Updated Deduct Credits button to only show if that user has more than 0 credits.
  • Updated Admin controller:
    • Updated setCredits() method to return the amount of credits after the operation.
    • Added validation to banUser() method to prevent the user from banning themselves (including if they are impersonating another user).
    • Added validation to impersonate() method to prevent the user from impersonating themselves, or trying to impersonate another user while they are already impersonating a user.
  • Updated AddWarning component:
    • Updated button to use btn-success CSS class instead of btn-default.
    • Slightly improved layout.
    • Updated layout for narrow screen sizes (eg mobile screens).

@Metritutus Metritutus force-pushed the fixes009 branch 4 times, most recently from 1668bc3 to 55c3f48 Compare October 27, 2024 13:31
@SpacialCircumstances SpacialCircumstances added this to the Update 247 milestone Oct 27, 2024
…t the carrier is being built with a whole number of ships.

* Removed ownedByPlayer property from MapObject.  Replaced with dynamic value resolution in the client for the tables that used this property for sorting.
* Added the ability to end user impersonation.
* Added new sessionService.
* Updated SessionData interface to include other properties that are already being used in uses of SessionData.
* Updated numerous areas that would adjust data that was also stored in user sessions to also update that user's sessions so that the data is aligned.
* Updated listUsers() method in AdminService to query the database for the user's roles rather than using their session data.
* Updated setCredits() method in UserService to return the amount of credits set.
* Updated Users component:
    - Updated to show/hide certain settings based on the user's roles.
    - Updated to update the current administrator user's credits/roles in their local session if they are adjusting themselves.
    - Updated Deduct Credits button to only show if that user has more than 0 credits.
* Updated Admin controller:
    - Updated setCredits() method to return the amount of credits after the operation.
    - Added validation to banUser() method to prevent the user from banning themselves (including if they are impersonating another user).
    - Added validation to impersonate() method to prevent the user from impersonating themselves, or trying to impersonate another user while they are already impersonating a user.
* Updated AddWarning component:
    - Updated button to use btn-success CSS class instead of btn-default.
    - Slightly improved layout.
    - Updated layout for narrow screen sizes (eg mobile screens).
* Updated "test" script configuration in package.json to load all files specified in tsconfig.json.
@SpacialCircumstances SpacialCircumstances changed the base branch from master to update/247 October 27, 2024 15:16
@SpacialCircumstances SpacialCircumstances merged commit 57fa004 into solaris-games:update/247 Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants