New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "\n", "\t", "\r" to test case #1106

Closed

alexander-schranz wants to merge 3 commits into solariumphp:master from alexander-schranz:patch-1

Contributor

alexander-schranz commented Nov 21, 2023 •

edited

Loading

Add some more test cases: #1104

alexander-schranz added 3 commits

November 21, 2023 22:22


          Add "\n", "\t", "\r" to test case

2d43b0d


          Fix code style

67839d1


          Fix code style

e53bf60

alexander-schranz mentioned this pull request

EscapePhrase with \r does not work #1104

Closed

Member

thomascorthals commented Nov 21, 2023

#1107 has a working test that incorporates the test phrase from #1104 and accounts for XML's handling of \r.

thomascorthals closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet