Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for WT_PHPS #1110

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

thomascorthals
Copy link
Member

There wasn't a single integration test that used WT_PHPS to validate that #1109 doesn't break anything (even though I really don't see how it could).

I've added a dataProvider that lets you repeat the same test with multiple responseWriters, and a way to cross it with the dataProvider for update request formats.

Had to skip tests that use the Spellcheck component. It appears to have a few bugs when parsing PHPS but the response is too complicated to figure it out now.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77c1ddb) 97.49% compared to head (a57aa88) 97.49%.
Report is 1 commits behind head on master.

❗ Current head a57aa88 differs from pull request most recent head aa17d07. Consider uploading reports for the commit aa17d07 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         391      391           
  Lines       10150    10150           
=======================================
  Hits         9896     9896           
  Misses        254      254           
Flag Coverage Δ
unittests 97.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit ddc6da2 into solariumphp:master Dec 1, 2023
8 of 26 checks passed
@thomascorthals thomascorthals deleted the tests branch December 1, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants