Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There wasn't a single integration test that used
WT_PHPS
to validate that #1109 doesn't break anything (even though I really don't see how it could).I've added a dataProvider that lets you repeat the same test with multiple responseWriters, and a way to cross it with the dataProvider for update request formats.
Had to skip tests that use the Spellcheck component. It appears to have a few bugs when parsing PHPS but the response is too complicated to figure it out now.