Integration test for labelled children in nested documents #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to exclude the test for atomic updates of anonymous children from SolrCloud mode. Occasionally it would pass, but on most of my runs (both locally and on GitHub) it would result in an error for 1 or 2 of the 3 adapters. It's not the same adapters every time and I've never seen it fail on all 3 adapters in the same run. I couldn't find anything about it on Solr's JIRA. |
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=========================================
Coverage 91.21% 91.21%
Complexity 3802 3802
=========================================
Files 328 328
Lines 8146 8146
=========================================
Hits 7430 7430
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mkalkbrenner
requested changes
Dec 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #870. This also closes #717. This also closes #577.
The integration test adds nested documents and queries them both with a
[child]tranformer and block join queries. There's quite some differences between Solr 7 and Solr 8 when using[child]. Between this test and the one for anonymous children, I believe I have all possibilities covered.Solr 7 has no support for atomic updates of child documents. Solr 8 does, but they don't work with XML update requests because of SOLR-12677. In spite of the claim there, I also couldn't get them to work with anonymous children. That might be because I introduced a
_nest_path_field in our schema to fully support labelled children. You probably shouldn't use the combination of_nest_path_and anonymous children in a production environment.One exception is removing all child documents by setting them to
[]. There doesn't need to be any nested data in the XML for that atomic update and it does result in the expected behaviour. I've set a watch on SOLR-12677. When it gets fixed, I'll expand the test to cover the full range of atomic operations.