NH-5044: Fix NPE issue unboxing null #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted the
NH-5044-npe-unboxing-null
branch
March 16, 2022 18:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AppOpticsProfilingSpanProcessorthemetadata.getTraceID()is called and the returned id inLongtype is used as the key of the Profiler. However, if the method above returns null it cannot be unboxed to the primitive typelongand will throw an NullPointerException.This PR changes the profiler map to use the hex string of the trace id as the key. The hex string trace id is converted from the byte array by calling
metadata.getTaskID(), which always has a value when the metadata is valid.See also https://github.com/librato/joboe/pull/1509