NH-20004: NH Java agent: upgrade Otel dependency to the latest version #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # custom/src/main/java/com/appoptics/opentelemetry/extensions/AppOpticsTracerProviderConfigurer.java
# Conflicts: # instrumentation/servlet/servlet-3.0/javaagent/src/main/java/com/appoptics/opentelemetry/instrumentation/servlet/v3_0/Servlet3Advice.java # instrumentation/servlet/servlet-5.0/javaagent/src/main/java/com/appoptics/opentelemetry/instrumentation/servlet/v5_0/service/JakartaServletServiceAdvice.java
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - uncomment checkstyle config - fix compile error
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - bump version to 1.22.0 - refactor deprecated API usage
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - remove reference to SL4J logger due to issue with class loading - exclude resource from shadow relocation - exclude `io/opentelemetry/javaagent/shaded/instrumentation/api/**` from angent loader path as this is available in the bootstrap path.
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - problem *solved* (mostly :) - use standard project structure - use build configuration similar demo [distro](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/examples/distro)
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - remove unnecessary deps
chukwubuikem-umeugwa_swi
mannequin
changed the title
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - It turns out that we have to use the builder to create a working tracer. Though using `GlobalOpenTelemetry` is still viable, it is actually discouraged and requires nasty workaround. With the new release the tooling that made using `GlobalOpenTelemetry` work were removed(`ApplicationTracer`).
chukwubuikem-umeugwa_swi
mannequin
force-pushed
the
cc/NH-20004-nuke
branch
from
ec445be to
c617bf6
Compare
chukwubuikem-umeugwa_swi
mannequin
requested review from
ghost and
Lin-Lin_swi
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - configure maven local publication and add script
...c/main/java/com/appoptics/opentelemetry/extensions/AppOpticsInboundMetricsSpanProcessor.java
Show resolved
Hide resolved
custom/src/main/java/com/appoptics/opentelemetry/extensions/initialize/Initializer.java
Outdated
Show resolved
Hide resolved
...ppoptics/opentelemetry/instrumentation/servlet/v5_0/service/JakartaServletServiceAdvice.java
Outdated
Show resolved
Hide resolved
- [JIRA](https://swicloud.atlassian.net/browse/NH-20004) - remove shadow tasks from agent libs build.gradle - exclude bootstrap classes from agent class loader path
There was a problem hiding this comment.
Wow, thank you for sorting through the rat's nest of classloading and upstream changes and putting our distro, finally, in a much better place @cleverchuk! (guess what, OTel 1.23.0 is on the way ;))
I didn't do so much a code review as a set of manual tests, checking some basic functionality like:
- trace spans, metrics, profiling spans - OK
- recent exporter and __Init message changes - OK
- your fix to response header - OK
One representative trace in staging being https://my.na-01.st-ssp.solarwinds.com/136477216875174912/traces/2EDFF3AEBCCF3EB2245CCA697712C099/4FE52F36BDD41034/details/breakdown?duration=3600, which has errors and code profiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this and this ticket.
To accomplish this, the project was refactored to follow similar configuration as is found here and ensuring that any dependency on OTEL is added using
compileOnlyconfiguration. This ensures that bootstrap class loader and the agent class loader don't end up loading the same exact class.The
buildSrcdirectory was removed because the new build configuration uses the Gradle instrumentation plugin making it unnecessary. Also added maven local repository installation to facilitate local testing