Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-76572 - Added mock interface #4

Merged
merged 5 commits into from
Jun 7, 2024
Merged

NH-76572 - Added mock interface #4

merged 5 commits into from
Jun 7, 2024

Conversation

jerrytfleung
Copy link
Contributor

@jerrytfleung jerrytfleung commented Jun 7, 2024 •
edited by jira bot
Loading

Description of changes:

Added mock interface for apm-proto go

Related issues

NH-76572

@jerrytfleung jerrytfleung requested a review from a team as a code owner June 7, 2024 23:18
cheempz
cheempz approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerrytfleung jerrytfleung merged commit 3aa8cac into main Jun 7, 2024
1 check passed
@jerrytfleung jerrytfleung deleted the mock branch June 7, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrytfleung @cheempz