Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-76572 - Removed maven release plugin #6

Merged
merged 17 commits into from
Jun 13, 2024
Merged

NH-76572 - Removed maven release plugin #6

merged 17 commits into from
Jun 13, 2024

Conversation

jerrytfleung
Copy link
Contributor

@jerrytfleung jerrytfleung commented Jun 11, 2024 •
edited by jira bot
Loading

Description of changes:

  • Removed maven release plugin
  • Updated Makefile
  • Removed go.mod and go.sum

Related issues

NH-76572

@jerrytfleung jerrytfleung changed the title Test tag Fixed maven release plugin issues Jun 11, 2024
@jerrytfleung jerrytfleung changed the title Fixed maven release plugin issues Removed maven release plugin Jun 11, 2024
@jerrytfleung jerrytfleung changed the title Removed maven release plugin NH-76572 - Removed maven release plugin Jun 11, 2024
@jerrytfleung jerrytfleung marked this pull request as ready for review June 11, 2024 21:08
@jerrytfleung jerrytfleung requested a review from a team as a code owner June 11, 2024 21:08
@jerrytfleung jerrytfleung requested a review from cleverchuk June 11, 2024 21:08
cleverchuk
cleverchuk reviewed Jun 12, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
swi-jared
swi-jared reviewed Jun 12, 2024
View reviewed changes
go/collectorpb/go.mod Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

@jerrytfleung jerrytfleung Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jerrytfleung jerrytfleung merged commit 632ba12 into main Jun 13, 2024
1 check passed
@jerrytfleung jerrytfleung deleted the test_tag branch June 13, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swi-jared swi-jared swi-jared left review comments

@cleverchuk cleverchuk cleverchuk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrytfleung @cleverchuk @swi-jared