Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-65932 Testrelease 0.18.0.X #208

Merged
merged 2 commits into from
Oct 30, 2023
Merged

NH-65932 Testrelease 0.18.0.X #208

merged 2 commits into from
Oct 30, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Oct 30, 2023 •
edited
Loading

Testrelease 0.18.0.16

Notes:

  • Quite a few changes since 0.17.0 I forgot to add to Changelog, so added here
  • Testrelease version is high because of several previous publishes used to lambda layer tests

tox tests pass on this PR.

Test traces, still with spaces in span names yay:

Published to TestPyPI at: https://test.pypi.org/project/solarwinds-apm/0.18.0.16/#files

Install-from-TestPyPI tests: https://github.com/solarwindscloud/solarwinds-apm-python/actions/runs/6699082317

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review October 30, 2023 21:51
@tammy-baylis-swi tammy-baylis-swi requested a review from a team October 30, 2023 21:51
cheempz
cheempz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @tammy-baylis-swi!

@tammy-baylis-swi tammy-baylis-swi merged commit 69ad14c into main Oct 30, 2023
73 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-65932-testrelease-0_18_0_x branch October 30, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz