Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-66478 Update pyproject.toml, remove setup.cfg, no more .so.0 symlink, fix smoke tests #273

Merged
merged 21 commits into from
Jan 11, 2024
Merged

NH-66478 Update pyproject.toml, remove setup.cfg, no more .so.0 symlink, fix smoke tests #273

merged 21 commits into from
Jan 11, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jan 5, 2024 •
edited
Loading

This PR adjusts APM Python build configuration so that Dependabot can detect all dependencies!! 🙃 Details in https://swicloud.atlassian.net/browse/NH-66478

  1. Moves all that was in setup.cfg to pyproject.toml, and removes setup.cfg.
  2. Stops creating the symlink liboboe.so.0 which I'm pretty sure hasn't been used by any type of build in a long time.
  3. Fixes smoke tests for c-lib 14. Ubuntu 18 needs older checkout version for Node 16 and older glibc.
  4. Bumps version to 1.1.0.2 for a testrelease to make sure builds still work and smoke tests pass.

@tammy-baylis-swi tammy-baylis-swi changed the title NH-66478 Update pyproject.toml, remove setup.cfg NH-66478 Update pyproject.toml, remove setup.cfg, no more .so.0 symlink Jan 9, 2024
@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-66478-update-pyproject-toml branch from 00a4b60 to 2ae41e3 Compare January 9, 2024 23:19
@tammy-baylis-swi tammy-baylis-swi changed the title NH-66478 Update pyproject.toml, remove setup.cfg, no more .so.0 symlink NH-66478 Update pyproject.toml, remove setup.cfg, no more .so.0 symlink, fix smoke tests Jan 10, 2024
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review January 10, 2024 01:33
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner January 10, 2024 01:33
cheempz
cheempz approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really awesome that you achieved the migration to pyproject! Thanks as always for the nice PR description with links to test evidence :)

@tammy-baylis-swi tammy-baylis-swi merged commit 7d9ad3e into main Jan 11, 2024
@tammy-baylis-swi tammy-baylis-swi deleted the NH-66478-update-pyproject-toml branch January 11, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz