[WIP/PoC] NH-75342 refactor config and logging #355
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| logger.debug( | ||
| "Set up transaction filters: %s", | ||
| self.__config["transaction_filters"], |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| else: | ||
| logger.warning( | ||
| "Ignore invalid configuration key: %s", | ||
| ".".join(keys), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| except (ValueError, TypeError): | ||
| logger.warning( | ||
| "Ignore config option with invalid (non-convertible or out-of-range) type: %s", | ||
| ".".join(keys if keys[0] != "transaction" else keys[1:]), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| with open(env_filepath, "x", encoding="utf-8") as env_file: | ||
| for config_key, config_value in self.__config.items(): | ||
| # TODO transactionSettings dumps | ||
| env_file.write(f"{config_key}={config_value}\n") |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information High
| @@ -88,6 +89,10 @@ | |||
| """Configure SolarWinds APM and OTel components""" | |||
| apm_txname_manager = SolarWindsTxnNameManager() | |||
| apm_fwkv_manager = SolarWindsFrameworkKvManager() | |||
|
|
|||
| # TODO Use to init/merge/?? with ApmConfig | |||
| user_config = extract_user_config() | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
WIP/PoC to split current ApmConfig into two parts init'd by distro then configurator.