Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/PoC] NH-75342 Set logging handler based on log_correlation #356

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Apr 9, 2024

Sets APM Python logging handler based on OTel log_correlation. If correlation enabled, then APM relies on upstream LoggingInstrumentor setup of StreamHandler. If not, APM sets up StreamHandler itself.

Adds quick workaround that adds StreamHandler to distro, ApmConfig, configurator loggers during startup if needed so that they always log but never in duplicate.

@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-75342-stop-dupe-logs branch from 4001d1b to 99181aa Compare April 9, 2024 22:59
@tammy-baylis-swi tammy-baylis-swi changed the title [WIP/PoC] NH-75342 Set logging handler based on log_correlation NH-75342 Set logging handler based on log_correlation Apr 9, 2024
@tammy-baylis-swi tammy-baylis-swi changed the title NH-75342 Set logging handler based on log_correlation [WIP/PoC] NH-75342 Set logging handler based on log_correlation Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant