-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-94756: dbo for mysql2 #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @xuan-cao-swi! I made some suggestions to update the file headings. More important, is it possible to add some tests to verify the comment insertion and config option control?
Co-authored-by: Lin Lin <lin.lin@solarwinds.com>
Co-authored-by: Lin Lin <lin.lin@solarwinds.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting verrrry close @xuan-cao-swi! Some minor suggestions and one ask--can you check whether these new patch tests are actually run? Not seeing them in the Rakefile task nor the GHA worfklow output.
I have to execute the mysql2 test case separately in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xuan-cao-swi!
Description
Trace injection to mysql2 instrumentation
Other changes:
oboe_config_get_revision
Test (if applicable)
Prod