Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use Correct OTLP Port Number in Exporters #9

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[fix] Use Correct OTLP Port Number in Exporters #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/solarwindsextension/internal/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ func (cfg *Config) EndpointUrl() (string, error) {
// dataCenterToURLMapping maps a data center ID to
// to its corresponding OTLP endpoint URL.
var dataCenterToURLMapping = map[string]string{
"na-01": "otel.collector.na-01.cloud.solarwinds.com:4317",
"na-02": "otel.collector.na-02.cloud.solarwinds.com:4317",
"eu-01": "otel.collector.eu-01.cloud.solarwinds.com:4317",
"na-01": "otel.collector.na-01.cloud.solarwinds.com:443",
"na-02": "otel.collector.na-02.cloud.solarwinds.com:443",
"eu-01": "otel.collector.eu-01.cloud.solarwinds.com:443",
}

// lookupDataCenterURL returns the OTLP endpoint URL
Expand Down
8 changes: 4 additions & 4 deletions extension/solarwindsextension/internal/datacell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ func TestConfigValidateDataCenters(t *testing.T) {
}

tests := []test{
{dataCenter: "na-01", url: "otel.collector.na-01.cloud.solarwinds.com:4317", ok: true},
{dataCenter: "na-02", url: "otel.collector.na-02.cloud.solarwinds.com:4317", ok: true},
{dataCenter: "eu-01", url: "otel.collector.eu-01.cloud.solarwinds.com:4317", ok: true},
{dataCenter: "NA-01", url: "otel.collector.na-01.cloud.solarwinds.com:4317", ok: true},
{dataCenter: "na-01", url: "otel.collector.na-01.cloud.solarwinds.com:443", ok: true},
{dataCenter: "na-02", url: "otel.collector.na-02.cloud.solarwinds.com:443", ok: true},
{dataCenter: "eu-01", url: "otel.collector.eu-01.cloud.solarwinds.com:443", ok: true},
{dataCenter: "NA-01", url: "otel.collector.na-01.cloud.solarwinds.com:443", ok: true},
{dataCenter: "apj-01", url: "", ok: false},
}

Expand Down
Loading