Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed name and version from the scope context #797

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

turytsia
Copy link
Contributor

Summary

This PR removes name and version from the scope context

Before

{
    "resourceMetrics": [
        {
            "resource":  ...
            "scopeMetrics": [
                {
                    "scope": {
                        "name": "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver",
                        "version": "0.11.4"
                    }
                }
            ]
        }
    ]
}

After

{
    "resourceMetrics": [
        {
            "resource":  ...
            "scopeMetrics": [
                {
                    "scope": { }
                }
            ]
        }
    ]
}

@turytsia turytsia requested a review from a team as a code owner November 14, 2024 12:46
Copy link
Contributor

@gantrior gantrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@turytsia turytsia merged commit 5da5aba into master Nov 15, 2024
19 checks passed
@turytsia turytsia deleted the remove-name-and-version-from-scope branch November 15, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants