-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect labels and annotations from manifest #808
Collect labels and annotations from manifest #808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess those failures in CI are not random. Tests are checking if the telemetry have labels and annotations in it and you are removing it: https://github.com/solarwinds/swi-k8s-opentelemetry-collector/blob/master/tests/integration/expected_telemetry/deployment.json#L22-L23. So you will need to update those expected telemetry in tests.
…e warnings when there are no labels/annotations
fffb45a
to
2e0a8b6
Compare
…rom-manifests' into collect-labels-and-annotations-from-manifests
resource.attributes
kvlistValue
was removedk8s_instrumentation
config is ignored