Prevent invalid metric filter creation in alert resources #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grepory
force-pushed
the
grepory/invalid-metric-filter
branch
2 times, most recently
from
4d12d1d to
d92551b
Compare
When no include_tags or exclude_tags are provided for alert resources, an empty metric filter object with the AND operator was created on the metric condition. This can yield errors in the backend. Do not instantiate a metric filter unless there are tags to include/exclude. Guard against missing optional fields in alert resources
grepory
force-pushed
the
grepory/invalid-metric-filter
branch
from
d92551b to
e140ba8
Compare
michael-anderson-swi
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no include_tags or exclude_tags are provided for alert resources, an empty metric filter object with the AND operator was created on the metric condition. This can yield errors in the backend. Do not instantiate a metric filter unless there are tags to include/exclude.
While I was at it, I also did some typo cleanup and removed the unused/undocumented "type" field from the alert resource.