Fix temporary hang in strings tool when limit is reached (#217).

CHANGES.txt

@@ -6,6 +6,8 @@ Version TBA
 
  * Add copy/export context menu commands to strings tool (#210).
 
+ * Fix temporary hang in strings tool when processing large files (#217).
+
 Version 0.60.1 (2023-07-28)
 
  * Install missing parts of binary template plugin.

src/StringPanel.cpp

@@ -598,12 +598,12 @@ void REHex::StringPanel::thread_main()
 
  is_really_string = is_i_string(true);
 
- while(!threads_pause && i < data.size() && is_i_string(false) == is_really_string)
+ while(!threads_pause && !threads_exit && i < data.size() && is_i_string(false) == is_really_string)
  {
  ++num_codepoints;
  }
 
- if(threads_pause)
+ if(threads_pause || threads_exit)
  {
  /* We are being paused to allow for data being inserted or erased.
  * This may invalidate the base and/or length of our window, so we
@@ -630,6 +630,12 @@ void REHex::StringPanel::thread_main()
 
  --running_threads;
 
+ if(threads_exit)
+ {
+ --spawned_threads;
+ return;
+ }
+
  paused_cv.notify_all();
  resume_cv.wait(pl, [this]() { return !threads_pause; });