persistence: Fix resource leak

File was not being closed upon write failure. Signed-off-by: Ederson de Souza <ederson.desouza@intel.com>
solettaproject · Sep 3, 2015 · 3090e04 · 3090e04
1 parent 32d13ad
commit 3090e04
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/modules/flow/persistence/fs-storage.c b/src/modules/flow/persistence/fs-storage.c
@@ -48,6 +48,7 @@ int
 fs_write(const char *name, struct sol_buffer *buffer)
 {
     FILE *file;
+    int ret = 0;
 
     file = fopen(name, "w+e");
     if (!file) {
@@ -58,15 +59,15 @@ fs_write(const char *name, struct sol_buffer *buffer)
     fwrite(buffer->data, buffer->used, 1, file);
     if (ferror(file)) {
         SOL_WRN("Could not write to persistence file [%s]", name);
-        return -EIO;
+        ret = -EIO;
     }
 
     if (fclose(file)) {
         SOL_WRN("Could not close persistence file [%s]", name);
         return -errno;
     }
 
-    return 0;
+    return ret;
 }
 
 int