buffer: Fix heap overflow when ensuring empty buffer is NUL-terminated

Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
solettaproject · Sep 29, 2015 · 4975b55 · 4975b55
1 parent 321ee58
commit 4975b55
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib/datatypes/sol-buffer.c b/src/lib/datatypes/sol-buffer.c
@@ -331,7 +331,7 @@ sol_buffer_ensure_nul_byte(struct sol_buffer *buf)
     if (buf->flags & SOL_BUFFER_FLAGS_NO_NUL_BYTE)
         return -EINVAL;
 
-    if (*((char *)sol_buffer_at_end(buf) - 1) == '\0')
+    if (buf->used && *((char *)sol_buffer_at_end(buf) - 1) == '\0')
         return 0;
 
     if (buf->used >= SIZE_MAX - 1 ||