Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Commit

Permalink
comms:http:client: Fix possible segfault
Browse files Browse the repository at this point in the history
Do not destroy/release curl's resources inside its own callback.

It was calling call_connection_finish_cb() (that calls
destroy_connection()) inside the curl's progress callback for that connection.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  • Loading branch information
ceolin committed Sep 18, 2015
1 parent 75483cb commit 646233f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/lib/comms/sol-http-client-impl-curl.c
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,6 @@ xferinfo_cb(void *clientp, curl_off_t dltotal, curl_off_t dlnow,
return 1;
}

if (dltotal && dltotal == dlnow)
call_connection_finish_cb(connection);

return 0;
}

Expand Down

0 comments on commit 646233f

Please sign in to comment.