common/platform-linux: fix leaking on parse_mount_point_file error

It could leaks a buffer. Signed-off-by: Bruno Dilly <bruno.dilly@intel.com>
solettaproject · Nov 10, 2015 · a7d4334 · a7d4334
1 parent 9c7ba25
commit a7d4334
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/lib/common/sol-platform-linux-common.c b/src/lib/common/sol-platform-linux-common.c
@@ -311,7 +311,7 @@ parse_mount_point_file(const char *file, struct sol_ptr_vector *vector)
     struct mntent mbuf;
     struct mntent *m;
     char strings[4096];
-    struct sol_buffer *itr;
+    struct sol_buffer *itr, *buff = NULL;
     uint16_t i;
     FILE *tab = setmntent(file, "re");
 
@@ -327,7 +327,6 @@ parse_mount_point_file(const char *file, struct sol_ptr_vector *vector)
     }
 
     while ((m = getmntent_r(tab, &mbuf, strings, sizeof(strings)))) {
-        struct sol_buffer *buff = NULL;
         int r;
 
         buff = sol_buffer_new();
@@ -343,6 +342,7 @@ parse_mount_point_file(const char *file, struct sol_ptr_vector *vector)
     return 0;
 
 err:
+    sol_buffer_fini(buff);
     SOL_PTR_VECTOR_FOREACH_IDX (vector, itr, i) {
         sol_buffer_fini(itr);
     }