refactor bookmark.getAll

solid-contrib · Nov 28, 2023 · 326effb · 326effb
1 parent 75dff1d
commit 326effb
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/bookmarks/vanilla/src/modules/Bookmark.ts b/bookmarks/vanilla/src/modules/Bookmark.ts
@@ -87,22 +87,23 @@ export class Bookmark {
      */
     public static async getAll(session: Session) {
         const indexUrls = await this.getIndexUrl(session);
-        const all = indexUrls.map(async (indexUrl) => {
-            try {
+        try {
+            const all = indexUrls.map(async (indexUrl) => {
                 const ds = await getSolidDataset(indexUrl, { fetch: session.fetch });
 
                 const things = getThingAll(ds)
 
                 const bookmarks = await things.map(thing => this.mapBookmark(thing))
 
                 return bookmarks
-            } catch (error) {
-                return []
-            }
-        })
-        const allPromise = Promise.all([...all]);
-        const values = (await allPromise).flat();
-        return values;
+            })
+            const allPromise = Promise.all([...all]);
+            const values = (await allPromise).flat();
+            return values;
+        } catch (error) {
+            return []
+        }
+
     }
 
     /**