-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container url missing trailing slash #19
Conversation
I'm reading the Components.js docs and also trying to figure out which part of our storage config loads this particular file. |
…b/main/config/storage/backend/file.json into our own config instead of having it as an import
I unwrapped one layer of config import, and now it looks like the next config file points to FileDataAccessor which is a DataAccessor. Hm. Is anything inheriting from DataAccessorBasedStore? Where in the config does it choose to use that class? And what is the relationship between the config/ and the templates/config/ folder in the CSS repo? |
There is an issue with the tsconfig of this repo apparently, should set it to whatever CSS has, so I can edit src/ files from CSS here. |
I got it working but to get there I had to import all the CSS code. I did add CSS as a dependency and tried to import from there, but was having some trouble getting Components.js to understand that. I also don't know if I should use pivot or css as the namespace for LSD. |
another problem seems to be that it looks like the path for class imports should be e.g.:
but for types it seems that this leads to a double |
and mixing between code in CSS and code in Pivot leads to awkard things like this one:
|
So will leave it with duplicate code for now. The interaction between npm package management and Components.js component management is really making this complex. |
I was able to resolve the duplicate code issue later in #22. |
I copied the file to be changed into
src/
on this branch.Now figuring out how to add Components.js config to override it to use my copy of the file.
Then I can edit the behaviour.