Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container url missing trailing slash #19

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

michielbdejong
Copy link
Collaborator

I copied the file to be changed into src/ on this branch.
Now figuring out how to add Components.js config to override it to use my copy of the file.
Then I can edit the behaviour.

@michielbdejong michielbdejong linked an issue Nov 5, 2024 that may be closed by this pull request
@michielbdejong
Copy link
Collaborator Author

I'm reading the Components.js docs and also trying to figure out which part of our storage config loads this particular file.

@michielbdejong
Copy link
Collaborator Author

I unwrapped one layer of config import, and now it looks like the next config file points to FileDataAccessor which is a DataAccessor. Hm. Is anything inheriting from DataAccessorBasedStore?

Where in the config does it choose to use that class?

And what is the relationship between the config/ and the templates/config/ folder in the CSS repo?

@michielbdejong
Copy link
Collaborator Author

There is an issue with the tsconfig of this repo apparently, should set it to whatever CSS has, so I can edit src/ files from CSS here.

@michielbdejong
Copy link
Collaborator Author

I got it working but to get there I had to import all the CSS code. I did add CSS as a dependency and tried to import from there, but was having some trouble getting Components.js to understand that. I also don't know if I should use pivot or css as the namespace for LSD.

@michielbdejong
Copy link
Collaborator Author

another problem seems to be that it looks like the path for class imports should be e.g.:

export * from '@solid/community-server/dist/pods/generate/TemplatedResourcesGenerator';

but for types it seems that this leads to a double dist/dist/ in the path

@michielbdejong
Copy link
Collaborator Author

and mixing between code in CSS and code in Pivot leads to awkard things like this one:

Argument of type
'import("/Users/michiel/gh/solid-contrib/pivot/
node_modules/@solid/community-server/dist/http/representation/Representation").Representation'
is not assignable to parameter of type
'import("/Users/michiel/gh/solid-contrib/pivot/
src/http/representation/Representation").Representation'.

@michielbdejong
Copy link
Collaborator Author

So will leave it with duplicate code for now. The interaction between npm package management and Components.js component management is really making this complex.

@michielbdejong michielbdejong merged commit dbfcec6 into main Nov 7, 2024
@michielbdejong michielbdejong deleted the container-url-missing-trailing-slash branch November 7, 2024 15:56
@michielbdejong
Copy link
Collaborator Author

I was able to resolve the duplicate code issue later in #22.

michielbdejong added a commit that referenced this pull request Nov 21, 2024
Due to #29 I'm disabling the code from #19 and using the upstream code.

This means that #4 is now fully unsupported again (both for public and for non-public resources)
michielbdejong added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display containers even if trailing slash is missing from the URL
1 participant