Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 sd-display main size variant #1355

Closed
4 of 9 tasks
MartaPintoTeixeira opened this issue Sep 5, 2024 · 0 comments · Fixed by #1412
Closed
4 of 9 tasks

fix: 🤔 sd-display main size variant #1355

MartaPintoTeixeira opened this issue Sep 5, 2024 · 0 comments · Fixed by #1412
Assignees
@yoezlem
Labels
🔧 code needs changes in code

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Sep 5, 2024 •
edited by yoezlem
Loading

Current behavior

Default size variant in code is XL
Default size variant in figma is 4xl

Expected behavior

Default to be 4xl

Steps to reproduce

Technical Information

Figma: https://www.figma.com/design/YDktJcseQIIQbsuCpoKS4V/Component-Docs?node-id=2705-24820&node-type=SECTION&t=6LITtAjEN23AWGNx-0

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@yoezlem yoezlem moved this from 🛠️ To be pre-refined to ⚙️ To be refined in Solid Design System Project Board Sep 13, 2024
@yoezlem yoezlem removed their assignment Sep 13, 2024
@yoezlem yoezlem added the 🔧 code needs changes in code label Sep 13, 2024
@yoezlem yoezlem mentioned this issue Sep 19, 2024
Merged
1 task
@yoezlem yoezlem self-assigned this Sep 19, 2024
@yoezlem yoezlem moved this from 🔖 Ready to 👀 In review in Solid Design System Project Board Sep 19, 2024
This was referenced Sep 23, 2024
Closed
Merged
@yoezlem yoezlem closed this as completed Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoezlem yoezlem

Labels
🔧 code needs changes in code
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🤔 sd-display main size variant solid-design-system/solid
2 participants
@yoezlem @MartaPintoTeixeira