fix: 🤔 sd-display main size variant #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoezlem
temporarily deployed
to
github-pages
GitHub Actions
Inactive
yoezlem
temporarily deployed
to
github-pages
GitHub Actions
Inactive
karlbaumhauer
changed the title
|
@yoezlem isn't that a breaking change? |
not sure 🤔 |
Hey @yoezlem I believe this is a breaking change considering that if you are using the component with the default size you would need to change the code since the default size is now different. (Issue link)[https://github.com//issues/1355] we opened an issue for this when we start re-writting this component, probably we have duplicated issues now fixed by this PR. |
|
Yes, this is a breaking change imo. It will affect the visual design of the applications where the component is used. |
|
Changed main branch to feat/breaking-changes |
This was referenced Sep 23, 2024
auroraVasconcelos
approved these changes
Sep 24, 2024
MartaPintoTeixeira
approved these changes
Sep 25, 2024
yoezlem
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The default size variant in code is now changed to 4xl.
Closes #1355.
Definition of Reviewable: