Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[dev]: ✨ implement A11y improvements to sd-quickfact #1500

Closed
2 of 9 tasks
Tracked by #1465
yoezlem opened this issue Oct 9, 2024 · 0 comments
Closed
2 of 9 tasks
Tracked by #1465

feat[dev]: ✨ implement A11y improvements to sd-quickfact #1500

yoezlem opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Subtask Epic subtasks

Comments

@yoezlem
Copy link
Contributor

yoezlem commented Oct 9, 2024

Description

This task describes the Storybook implementation for the sd-quickfact component as part of the A11y improvements outlined in Epic #1465.

A11y improvements for sd-quickfact can be found here: sd-quickfact Notes.


Comment

No critical issues found.

Notes

  • I don't know why you're using the header element here. Generally, it's okay, but please be aware that if this component is used outside landmerks (header, main, footer, article, section, etc. elements) the header element of the component turns into a banner landmark for the entire page.
  • According to the spec, role=button is not allowed on header elements.

Best Practices

  • Don’t make summaries too long in expandable quickfacts because they’re used as the label for the button.

Open Questions

  • Question1
  • Question2

DoR

  • Item has been estimated by the team
  • Item dependencies have been identified and documented

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@yoezlem yoezlem added 🔧 code needs changes in code Subtask Epic subtasks labels Oct 9, 2024
@yoezlem yoezlem changed the title feat[dev]: ✨ implement A11y improvements to sd-qucifact feat[dev]: ✨ implement A11y improvements to sd-quickfact Oct 9, 2024
@yoezlem yoezlem added the A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS label Oct 9, 2024
@coraliefeil coraliefeil moved this from 📋 Backlog to ⚙️ To be refined in Solid Design System Project Board Dec 6, 2024
@smfonseca smfonseca self-assigned this Dec 10, 2024
@smfonseca smfonseca moved this from ⚙️ To be refined to 🏗 In progress in Solid Design System Project Board Dec 10, 2024
@smfonseca smfonseca removed their assignment Dec 11, 2024
@smfonseca smfonseca moved this from 🏗 In progress to 🛠️ To be pre-refined in Solid Design System Project Board Dec 11, 2024
@karlbaumhauer karlbaumhauer added 🚧🛑🚧 BLOCKED 🚧🛑🚧 Item is blocked and cannot be continued. and removed 🚧🛑🚧 BLOCKED 🚧🛑🚧 Item is blocked and cannot be continued. labels Dec 13, 2024
@karlbaumhauer karlbaumhauer moved this from 🛠️ To be pre-refined to 🔖 Ready in Solid Design System Project Board Dec 13, 2024
@paulovareiro29 paulovareiro29 self-assigned this Dec 23, 2024
@paulovareiro29 paulovareiro29 moved this from 🔖 Ready to 👀 In review in Solid Design System Project Board Dec 23, 2024
@paulovareiro29 paulovareiro29 moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Dec 23, 2024
@paulovareiro29 paulovareiro29 moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Dec 30, 2024
paulovareiro29 added a commit that referenced this issue Jan 13, 2025
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1496 #1500

This PR addresses:
- Adapt sd-accordion HTML using `details` and `summary` elements
- Adapt expandable sd-quickfact HTML using `details` and `summary`
elements

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] relevant tickets are linked
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Subtask Epic subtasks
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants