fix: improving sd-header a11y #1668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auroraVasconcelos
added
the
A11y Audit
auroraVasconcelos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
🚀 Storybook has been deployed for branch |
auroraVasconcelos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
smfonseca
reviewed
Nov 21, 2024
| @@ -328,6 +328,7 @@ export default class SdDrawer extends SolidElement { | |||
| variant="tertiary" | |||
| size="lg" | |||
| part="close-button" | |||
| aria-expanded=${this.open ? 'true' : 'false'} | |||
There was a problem hiding this comment.
Suggested change
| aria-expanded=${this.open ? 'true' : 'false'} | |
| aria-expanded=${this.open} |
| @@ -11,7 +11,7 @@ export default { | |||
| }, | |||
| title: 'Templates/Header' | |||
| }; | |||
|
|
|||
| /** **Accessibility hint:** aria-expanded and aria-controls may be use for smaller screens to make header accessible */ | |||
There was a problem hiding this comment.
I think we can remove the "smaller screens..." part and just mention that these attributes should be set for accessibility purposes. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #1478 and #1519.
Definition of Reviewable: