Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improving sd-header a11y #1668

Merged
merged 22 commits into from
Dec 13, 2024
Merged

fix: improving sd-header a11y #1668

merged 22 commits into from
Dec 13, 2024

Conversation

auroraVasconcelos
Copy link
Contributor

Description:

Closes #1478 and #1519.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@auroraVasconcelos auroraVasconcelos added the A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

🚀 Storybook has been deployed for branch feat_sd-header-a11y

smfonseca
smfonseca reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing with VoiceOver in Safari, I feel we should have an announcement to when the drawer closes.

packages/components/src/components/drawer/drawer.ts Outdated Show resolved Hide resolved
packages/docs/src/stories/templates/header.stories.ts Outdated Show resolved Hide resolved
@smfonseca smfonseca removed their assignment Nov 21, 2024
@coraliefeil
Copy link
Contributor

LGTM. THX

@coraliefeil coraliefeil removed their assignment Nov 27, 2024
@auroraVasconcelos @smfonseca
Update packages/components/src/components/drawer/drawer.ts
c0c69a7 
Co-authored-by: Sergio Fonseca <42741644+smfonseca@users.noreply.github.com>
@yoezlem yoezlem removed their assignment Nov 28, 2024
@auroraVasconcelos @mariohamann
Update .changeset/chilled-queens-smash.md
dae4ed6 
Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@coraliefeil coraliefeil removed their assignment Dec 9, 2024
@karlbaumhauer karlbaumhauer removed their assignment Dec 11, 2024
@auroraVasconcelos auroraVasconcelos dismissed stale reviews from mariohamann and paulovareiro29 December 13, 2024 11:26

The requested changes have been handled

@auroraVasconcelos auroraVasconcelos merged commit c2fb231 into main Dec 13, 2024
12 of 13 checks passed
@auroraVasconcelos auroraVasconcelos deleted the feat/sd-header-a11y branch December 13, 2024 12:10
@auroraVasconcelos auroraVasconcelos mentioned this pull request Dec 13, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfonseca smfonseca smfonseca approved these changes

@paulovareiro29 paulovareiro29 paulovareiro29 approved these changes

@MartaPintoTeixeira MartaPintoTeixeira MartaPintoTeixeira approved these changes

@mariohamann mariohamann Awaiting requested review from mariohamann

Assignees

@mariohamann mariohamann

@Vahid1919 Vahid1919

@auroraVasconcelos auroraVasconcelos

@MartaPintoTeixeira MartaPintoTeixeira

Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements to sd-header
9 participants
@auroraVasconcelos @coraliefeil @mariohamann @smfonseca @paulovareiro29 @MartaPintoTeixeira @karlbaumhauer @Vahid1919 @yoezlem