Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sd-expandable a11y #1724

Open
wants to merge 14 commits into
base: next
Choose a base branch
from

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Dec 11, 2024

Description:

Closes #1476

This PR addresses:

  • Adjust sd-expandable spacings according to figma
  • Reorder of sd-expandable dom order. (button first so it is targetable by keyboard first)
  • Improvement of the sd-expandable template labels
  • Added accessibility hints to sd-expandable

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 26dc6dd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 11, 2024

🚀 Storybook has been deployed for branch fix_improve-sd-expandable-a11y

@MartaPintoTeixeira
Copy link
Contributor

Accessibility hints added in storybook were now added to figma.

@paulovareiro29
Copy link
Contributor Author

Hi @MartaPintoTeixeira @coraliefeil ,
I have adjusted the spacings between the content and the button to look like figma. In figma there is a spacing of 16px. Previously, on implementation, there was none.

@paulovareiro29 paulovareiro29 changed the base branch from main to next December 13, 2024 11:07
@smfonseca smfonseca changed the base branch from next to main December 13, 2024 14:22
@paulovareiro29 paulovareiro29 changed the base branch from main to next December 18, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements to sd-expandable
7 participants