Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sd-divider a11y #1751

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Dec 20, 2024

Description:

Closes #1497

This PR addresses:

  • Implement aria-orientation on sd-divider

Definition of Reviewable:

  • E2E tests (features, a11y, bug fixes) are created/updated
  • relevant tickets are linked

Copy link
Contributor

github-actions bot commented Dec 20, 2024

🚀 Storybook has been deployed for branch fix_improve-sd-divider-a11y

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 54bc357

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartaPintoTeixeira
Copy link
Contributor

UI changeset for sd-divider has been approved.
Note: when approving i had 53 things to check on changeset. After speaking with @paulovareiro29 we agreed that I would check only the sd-divider.
I would like to know why is this happening. Thx

@smfonseca smfonseca removed their assignment Jan 6, 2025
@paulovareiro29 paulovareiro29 merged commit f0fd5cb into next Jan 7, 2025
16 checks passed
@paulovareiro29 paulovareiro29 deleted the fix/improve-sd-divider-a11y branch January 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements to sd-divider
6 participants