Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid returning widgets lint improvement #139

Conversation

Viktor-Mudrytskyi
Copy link
Contributor

@Viktor-Mudrytskyi Viktor-Mudrytskyi commented Mar 13, 2024

Closes #68

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@yurii-prykhodko-solid yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor tweaks unrelated to code.

Copy link
Collaborator

@yurii-prykhodko-solid yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small naming suggestion on changelog. Let me know what you think.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Illia Romanenko <442086+illia-romanenko@users.noreply.github.com>
@yurii-prykhodko-solid yurii-prykhodko-solid merged commit b8d126d into solid-software:master Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve avoid_returning_widgets to ignore override methods
3 participants