Cleanup of lint creation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+18
to
+19
| factory AvoidReturningWidgetsRule.createRule(CustomLintConfigs configs) { | ||
| final rule = MetricRule( |
There was a problem hiding this comment.
This seems wrong semantically. AvoidReturningWidgetsRule isn't a metric, but uses a MetricRule for configuring itself.
There was a problem hiding this comment.
Do you think merging SolidLintRule and MetricRule into one thing and calling it SolidLint would be acceptable? Both rules and metrics are lints for us at the end of the day, so is it good?
There was a problem hiding this comment.
Yep. At the very least we can explore it. If it comes together logically -- why not.
Comment on lines
+6
to
+12
| abstract class SolidLintRule<T extends Object?> extends DartLintRule { | ||
| /// Constructor for [SolidLintRule] model. | ||
| SolidLintRule(this.config) : super(code: config.lintCode); | ||
|
|
||
| /// Configuration for a particular rule with all the | ||
| /// defined custom parameters. | ||
| final MetricRule<T> config; |
There was a problem hiding this comment.
Maybe we should merge SolidLintRule and MetricRule into a single entity? This would simplify the declaration of these rules also -- it will just be an override on the rule implementation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have more and more lints it's a good idea to split it, so we won't end up with a one giant method with all lints.
cc:
illia-romanenkoit was supposed to be Yurii