Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor assignments, permission scheme, and substantive changes #95

Merged
merged 20 commits into from
Aug 28, 2019

Conversation

justinwb
Copy link
Member

@justinwb justinwb commented Aug 3, 2019

This pull request aims to address the concerns raised across the issues and pull requests itemized below. Of particular note, it merges the branches in pulls #82 and #78, and discards #81, which was no longer necessary.

The changes proposed are the result of collaboration with many of the people involved in the issues and pulls listed. Most importantly, the issues have been discussed with @timbl directly, and the proposed approach related to editor assignments and the editorial team is his recommended solution.

@RubenVerborgh
Copy link
Contributor

👍

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have written two comments inline.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@acoburn
Copy link
Member

acoburn commented Aug 6, 2019

👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@kjetilk kjetilk self-requested a review August 8, 2019 19:40
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I'm 👍 I'm a bit unsure how large the editorial team will be an if it might grow out of proportion, but lets just see.

@Mitzi-Laszlo
Copy link
Contributor

What would be great to include as well is:

  • the aim/ scope of the specification
  • the aim/ scope of the roadmap
  • the aim/ scope of the documentation
  • the respective repositories to which proposals in the form of pull requests to the specification, roadmap, and documentation should be made
  • the aim of each repo and how it connects to this process

@justinwb
Copy link
Member Author

justinwb commented Aug 9, 2019

What would be great to include as well is:

  • the aim/ scope of the specification
  • the aim/ scope of the roadmap
  • the aim/ scope of the documentation
  • the respective repositories to which proposals in the form of pull requests to the specification, roadmap, and documentation should be made
  • the aim of each repo and how it connects to this process

@Mitzi-Laszlo Agree there's value in providing more context around these. Have created a new issue that we can use to track them: #104

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
editors.md Outdated Show resolved Hide resolved
@Mitzi-Laszlo
Copy link
Contributor

Who will be responsible for moderating the implementation of this process?

@RubenVerborgh
Copy link
Contributor

The community. It’s self-governing.

@justinwb justinwb requested a review from RubenVerborgh August 17, 2019 03:05
Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Justin!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned df05c4c#r316179594 .. leaving the response and possible action to your discretion.

Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions not crucial

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@justinwb justinwb merged commit 977578c into master Aug 28, 2019
@RubenVerborgh
Copy link
Contributor

Thank you @justinwb for getting this through 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process proposal Process proposal to be reviewed by Solid Director
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants