Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drafting SPARQL Update support #320

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Drafting SPARQL Update support #320

Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3193a36
Basic scaffolding for defining SPARQL Update in Solid
kjetilk Oct 11, 2021
829697f
Add source
kjetilk Oct 11, 2021
0a56dcd
Initial definition of SPARQL subset grammar
kjetilk Oct 11, 2021
b59fd2d
Fix missing curly brackets
kjetilk Oct 11, 2021
1b714f8
Don't number the appendix
kjetilk Oct 11, 2021
fbd5990
Simplify the BNF
kjetilk Oct 13, 2021
65cb624
Reintroduce DeleteWhere
kjetilk Oct 13, 2021
79d5021
Update change count
kjetilk Oct 13, 2021
fed2294
Adopt NSS behaviour for SPARQL Update
kjetilk Oct 14, 2021
7545e63
Propose to use the 422 response for outside of subset
kjetilk Oct 14, 2021
e7b3b07
Fix id
kjetilk Oct 15, 2021
9f483f5
Add overview section, link Yacker for completeness
kjetilk Oct 15, 2021
3210404
Merge pull request #321 from solid/experiment/sparql-update-simplify
kjetilk Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 156 additions & 0 deletions protocol.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,18 @@ <h3 property="schema:name">Writing Resources</h3>

<p><span about="" id="server-post-target-not-found" rel="spec:requirement" resource="#server-post-target-not-found"><span property="spec:statement">When a <code>POST</code> method request targets a resource without an existing representation, the <span rel="spec:requirementSubject" resource="spec:Server">server</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> respond with the <code>404</code> status code.</span></span> [<a href="https://github.com/solid/specification/issues/108#issuecomment-549448159" rel="cito:citesAsSourceDocument">Source</a>]</p>

<p>
<span about="" id="server-patch-sparql-update" rel="spec:requirement" resource="#server-patch-sparql-update"><span property="spec:statement">When the target resource of a <code>PATCH</code> request is represented by an <em>RDF document</em> [<cite><a class="bibref" href="#bib-rdf11-concepts">RDF11-CONCEPTS</a></cite>], <span rel="spec:requirementSubject" resource="spec:Server">servers</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> support changing the representation using the request body containing a subset of SPARQL Update as defined in the <a href="#sparql-update-subset">Appendix</a>.</span></span>
<span about="" id="server-patch-sparql-all" rel="spec:requirement" resource="#server-patch-sparql-all"><span property="spec:statement"> <span rel="spec:requirementSubject" resource="spec:Server">Servers</span> <span rel="spec:requirementLevel" resource="spec:MAY">MAY</span> further support SPARQL 1.1 Update [<cite><a class="bibref" href="#bib-sparql-overview">SPARQL</a></cite>],</span></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…but how will they indicate that they do? If not answered now, shall we leave a comment here pointing to an open issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two open issues to this: One is discovery, whether a client can discover that before issuing a request. I think that is something we shouldn't design in the immediate term unless you have a ready-made solution for that in CSS. SPARQL 1.1 has a service description that we could probably borrow from. The other is what happens if the server has to signal an error if it gets a query it does not support, or if the query tries to modify a different resource. That, I think, we need to define now. I had an issue for that in solid-contrib/query-panel#6 but since we don't have that forum, I guess I'll just propose something in subsequent commits. Always happy to hear about ways it is being done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the above; main action point would be to link to these from the spec test, to show that we are aware. We can then follow up at any point later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 422 stands out as the most appropriate status code for responding to a query that isn't supported. I added a commit with that. Do you think we need to record an issue in the spec text itself about discovery? I think we should have open issues in here on github, at least for now. Otherwise, it is going to be a lot of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I thought we also pointed to relevant issues on GitHub from the spec, but no strong opinion.

<span about="" id="server-patch-sparql-not-other" rel="spec:requirement" resource="#server-patch-sparql-not-other"><span property="spec:statement"> except that <span rel="spec:requirementSubject" resource="spec:Server">servers</span> <span rel="spec:requirementLevel" resource="spec:MUSTNOT">MUST NOT</span> allow a request with a <code>PATCH</code> method to change other resources than the target resource.</span></span> [<a href="https://github.com/solid/specification/issues/125#issuecomment-873035679" rel="cito:citesAsSourceDocument">Source</a>]
</p>

<p>
<span about="" id="server-patch-sparql-insert" rel="spec:requirement" resource="#server-patch-sparql-insert"><span property="spec:statement">When the request body of a <code>PATCH</code> request has a SPARQL Update query that contains an <code>INSERT</code> keyword, <span rel="spec:requirementSubject" resource="spec:Server">servers</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> treat the request as an <a href="#append-operation">Append operation</a>.</span></span>
<span about="" id="server-patch-sparql-where" rel="spec:requirement" resource="#server-patch-sparql-where"><span property="spec:statement">When the query contains a <code>WHERE</code> keyword, <span rel="spec:requirementSubject" resource="spec:Server">servers</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> treat the request as a <a href="#read-operation">Read operation</a>.</span></span>
<span about="" id="server-patch-sparql-delete" rel="spec:requirement" resource="#server-patch-sparql-delete"><span property="spec:statement">When the query contains a <code>DELETE</code> keyword, <span rel="spec:requirementSubject" resource="spec:Server">servers</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> treat the request as a <a href="#read-operation">Read</a> and <a href="#write-operation">Write operation</a>.</span></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about them being cumulative?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I'm inclined to say it is covered actually, as I say "contains"... Does it really need further elaboration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still be explicit; right now this could be read as a priority list (stop when match) or a cumulative list. The "contains" does not change that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ditch the 2112 and introduce a Request Actions concept? Each line could say "the Request Actions include Read operation."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like i'm missing a subtlety about why containing a DELETE implies READ.

</p>

<p><span about="" id="server-put-patch-auxiliary-resource" rel="spec:requirement" resource="#server-put-patch-auxiliary-resource"><span property="spec:statement">When a <code>PUT</code> or <code>PATCH</code> method request targets an auxiliary resource, the <span rel="spec:requirementSubject" resource="spec:Server">server</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> create or update it.</span></span> <span about="" id="server-post-slug-auxiliary-resource" rel="spec:requirement" resource="#server-post-slug-auxiliary-resource"><span property="spec:statement">When a <code>POST</code> method request with the <code>Slug</code> header targets an auxiliary resource, the <span rel="spec:requirementSubject" resource="spec:Server">server</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> respond with the <code>403</code> status code and response body describing the error.</span></span> [<a href="https://github.com/solid/specification/issues/42#issuecomment-616688848" rel="cito:citesAsSourceDocument">Source</a>]</p>

<p><span about="" id="server-protect-containment" rel="spec:requirement" resource="#server-protect-containment"><span property="spec:statement"><span rel="spec:requirementSubject" resource="spec:Server">Servers</span> <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> NOT allow HTTP <code>POST</code>, <code>PUT</code> and <code>PATCH</code> to update a container’s containment triples; if the server receives such a request, it <span rel="spec:requirementLevel" resource="spec:MUST">MUST</span> respond with a <code>409</code> status code.</span></span> [<a href="https://github.com/solid/specification/issues/40#issuecomment-573358652" rel="cito:citesAsSourceDocument">Source</a>]</p>
Expand Down Expand Up @@ -1045,6 +1057,148 @@ <h3 property="schema:name">Security and Privacy Review</h3>
</div>
</section>

<section class="appendix" id="sparql-update-subset" inlist="" rel="schema:hasPart" resource="#sparql-update-subset">
<h2 property="schema:name">Appendix - A subset of SPARQL Update for Solid</h2>
<div datatype="rdf:HTML" property="schema:description">
<section id="sparql-subset-grammar" inlist="" rel="schema:hasPart" resource="#sparql-subset-grammar">
<h3 property="schema:name">Grammar</h3>
<div class="note" id="sparql-subset-definition-note" inlist="" rel="schema:hasPart" resource="#sparql-subset-definition-note">
<h4 property="schema:name"><span>Note</span>: Definition of SPARQL Update Subset</h4>
<div datatype="rdf:HTML" property="schema:description">
<p>This specification alters the grammar of 10 rules in the original grammar of the SPARQL 1.1 Query Language [<cite><a class="bibref" href="#bib-sparql-overview">SPARQL</a></cite>] grammar and introduces another 10 new rules to accommodate for <code>INSERT DATA</code> and <code>DELETE DATA</code>, which was defined in the language definition but not precisely defined in the grammar. This specification references the original grammar definition where no changes were made.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"alter"—do we want to specifically add into the phrasing that it is compatible? Or does "subset" sufficiently capture that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that it covers that, but what matters is what is understood by implementors.... We need to figure out if a change to the semantics is required, I have the only 1 match in mind in particular.

</div>
</div>

<div class="grammarTable" datatype="rdf:HTML" property="schema:description">
<table>
<tbody>
<tr valign="baseline">
<td><code>[30p] </code></td>
<td><code><a id="rUpdate1" name="rUpdate1">Update1</a></code></td>
<td> ::= </td>
<td><code><a href="https://www.w3.org/TR/sparql11-query/#rPrologue">Prologue</a> ( <a href="#rInsertData">InsertData</a> | <a href="#rDeleteData">DeleteData</a> | <a href="#rModify">Modify</a> ) </code></td>
</tr>
kjetilk marked this conversation as resolved.
Show resolved Hide resolved
<tr valign="baseline">
<td><code>[38p] </code></td>
<td><code><a id="rInsertData" name="rInsertData">InsertData</a></code></td>
<td> ::= </td>
<td><code><span class="token">'INSERT DATA'</span> <span class="token">'{'</span> <a href="#rTripleData">TripleData</a> <span class="token">'}'</span> </code></td>
</tr>
<tr valign="baseline">
<td><code>[39p] </code></td>
<td><code><a id="rDeleteData" name="rDeleteData">DeleteData</a></code></td>
<td> ::= </td>
<td><code><span class="token">'DELETE DATA'</span> <span class="token">'{'</span> <a href="#rTripleData">TripleData</a> <span class="token">'}'</span> </code></td>
</tr>
<tr valign="baseline">
<td><code>[41p] </code></td>
<td><code><a id="rModify" name="rModify">Modify</a></code></td>
<td> ::= </td>
<td><code>( <a href="#rDeleteClause">DeleteClause</a> <a href="#rInsertClause">InsertClause</a>? | <a href="#rInsertClause">InsertClause</a> ) <span class="token">'WHERE'</span> <a href="#rGroupGraphPattern">GroupGraphPattern</a></code></td>
</tr>
<tr valign="baseline">
<td><code>[42p] </code></td>
<td><code><a id="rDeleteClause" name="rDeleteClause">DeleteClause</a></code></td>
<td> ::= </td>
<td><code><span class="token">'DELETE'</span> <span class="token">'{'</span> <a href="https://www.w3.org/TR/sparql11-query/#rTriplesTemplate">TriplesTemplate</a> <span class="token">'}'</span> </code></td>
</tr>
<tr valign="baseline">
<td><code>[43p] </code></td>
<td><code><a id="rInsertClause" name="rInsertClause">InsertClause</a></code></td>
<td> ::= </td>
<td><code><span class="token">'INSERT'</span> <span class="token">'{'</span> <a href="https://www.w3.org/TR/sparql11-query/#rTriplesTemplate">TriplesTemplate</a> <span class="token">'}'</span> </code></td>
</tr>
<tr valign="baseline">
<td><code>[52d] </code></td>
<td><code><a id="rTripleData" name="rTripleData">TripleData</a></code></td>
<td> ::= </td>
<td><code><a href="#rTriplesDataSameSubject">TriplesDataSameSubject</a> ( <span class="token">'.'</span> <a href="#rTripleData">TripleData</a>? )?</code></td>
</tr>
<tr valign="baseline">
<td><code>[53p] </code></td>
<td><code><a id="rGroupGraphPattern" name="rGroupGraphPattern">GroupGraphPattern</a></code></td>
<td> ::= </td>
<td><code><span class="token">'{'</span> <a href="#rGroupGraphPatternSub">GroupGraphPatternSub</a> ) <span class="token">'}'</span></code></td>
</tr>
<tr valign="baseline">
<td><code>[54p] </code></td>
<td><code><a id="rGroupGraphPatternSub" name="rGroupGraphPatternSub">GroupGraphPatternSub</a></code></td>
<td> ::= </td>
<td><code><a href="#rTriplesBlock">TriplesBlock</a></code></td>
</tr>
<tr valign="baseline">
<td><code>[55p] </code></td>
<td><code><a id="rTriplesBlock" name="rTriplesBlock">TriplesBlock</a></code></td>
<td> ::= </td>
<td><code><a href="https://www.w3.org/TR/sparql11-query/#rTriplesSameSubject">TriplesSameSubject</a> ( <span class="token">'.'</span> <a href="#rTriplesBlock">TriplesBlock</a>? )?</code></td>
</tr>
<tr valign="baseline">
<td><code>[75d] </code></td>
<td><code><a id="rTriplesDataSameSubject" name="rTriplesDataSameSubject">TriplesDataSameSubject</a></code></td>
<td> ::= </td>
<td><code><a href="https://www.w3.org/TR/sparql11-query/#rGraphTerm">GraphTerm</a> <a href="#rPropertyDataListNotEmpty">PropertyDataListNotEmpty</a> | <a href="#rTriplesDataNode">TriplesDataNode</a> <a href="#rPropertyDataList">PropertyDataList</a></code></td>
</tr>
<tr valign="baseline">
<td><code>[76d] </code></td>
<td><code><a id="rPropertyDataList" name="rPropertyDataList">PropertyDataList</a></code></td>
<td> ::= </td>
<td><code><a href="#rPropertyDataListNotEmpty">PropertyDataListNotEmpty</a>?</code></td>
</tr>
<tr valign="baseline">
<td><code>[77d] </code></td>
<td><code><a id="rPropertyDataListNotEmpty" name="rPropertyDataListNotEmpty">PropertyDataListNotEmpty</a></code></td>
<td> ::= </td>
<td><code><a href="#rVerb">Verb</a> <a href="#rObjectDataList">ObjectDataList</a> ( <span class="token">';'</span> ( <a href="#rVerb">Verb</a> <a href="#rObjectDataList">ObjectDataList</a> )? )*</code></td>
</tr>
<tr valign="baseline">
<td><code>[78p] </code></td>
<td><code><a id="rVerb" name="rVerb">Verb</a></code></td>
<td> ::= </td>
<td><code><a href="https://www.w3.org/TR/sparql11-query/#riri">iri</a> | <span class="token">'a'</span></code></td>
</tr>
<tr valign="baseline">
<td><code>[79d] </code></td>
<td><code><a id="rObjectDataList" name="rObjectDataList">ObjectDataList</a></code></td>
<td> ::= </td>
<td><code><a href="#rObjectData">ObjectData</a> ( <span class="token">','</span> <a href="#rObjectData">ObjectData</a> )*</code></td>
</tr>
<tr valign="baseline">
<td><code>[80d] </code></td>
<td><code><a id="rObjectData" name="rObjectData">ObjectData</a></code></td>
<td> ::= </td>
<td><code><a href="#rGraphDataNode">GraphDataNode</a></code></td>
</tr>
<tr valign="baseline">
<td><code>[98d] </code></td>
<td><code><a id="rTriplesDataNode" name="rTriplesDataNode">TriplesDataNode</a></code></td>
<td> ::= </td>
<td><code><a href="#rCollectionData">CollectionData</a> | <a href="#rBlankNodeDataPropertyList">BlankNodeDataPropertyList</a></code></td>
</tr>
<tr valign="baseline">
<td><code>[99d] </code></td>
<td><code><a id="rBlankNodeDataPropertyList" name="rBlankNodeDataPropertyList">BlankNodeDataPropertyList</a></code></td>
<td> ::= </td>
<td><code><span class="token">'['</span> <a href="#rPropertyDataListNotEmpty">PropertyDataListNotEmpty</a> <span class="token">']'</span></code></td>
</tr>
<tr valign="baseline">
<td><code>[102d] </code></td>
<td><code><a id="rCollectionData" name="rCollectionData">CollectionData</a></code></td>
<td> ::= </td>
<td><code><span class="token">'('</span> <a href="#rGraphDataNode">GraphDataNode</a>+ <span class="token">')'</span></code></td>
</tr>
<tr valign="baseline">
<td><code>[104d] </code></td>
<td><code><a id="rGraphDataNode" name="rGraphDataNode">GraphDataNode</a></code></td>
<td> ::= </td>
<td><code><a href="https://www.w3.org/TR/sparql11-query/#rGraphTerm">GraphTerm</a> | <a href="#rTriplesDataNode">TriplesDataNode</a></code></td>
</tr>
RubenVerborgh marked this conversation as resolved.
Show resolved Hide resolved
</tbody>
</table>
</div>
</section>
</div>
</section>

<section class="appendix" id="references" inlist="" rel="schema:hasPart" resource="#references">
<h2 property="schema:name">References</h2>
<div datatype="rdf:HTML" property="schema:description">
Expand Down Expand Up @@ -1100,6 +1254,8 @@ <h3 property="schema:name">Normative References</h3>
<dd><a href="https://httpwg.org/specs/rfc8288.html" rel="cito:citesAsAuthority"><cite>Web Linking</cite></a>. M. Nottingham. IETF. October 2017. Proposed Standard. URL: <a href="https://httpwg.org/specs/rfc8288.html">https://httpwg.org/specs/rfc8288.html</a></dd>
<dt id="bib-solid-oidc">[SOLID-OIDC]</dt>
<dd><a href="https://solid.github.io/solid-oidc/" rel="cito:citesAsAuthority"><cite>SOLID-OIDC</cite></a>. Aaron Coburn; elf Pavlik; Dmitri Zagidulin. W3C Solid Community Group. W3C Editor's Draft. URL: <a href="https://solid.github.io/solid-oidc/">https://solid.github.io/solid-oidc/</a></dd>
<dt id="bib-sparql-overview">[SPARQL]</dt>
<dd><a href="https://www.w3.org/TR/sparql11-overview/" rel="cito:citesAsAuthority"><cite>SPARQL 1.1 Overview</cite></a>. The W3C SPARQL Working Group. W3C. 21 March 2013. W3C Recommendation. URL: <a href="https://www.w3.org/TR/sparql11-overview/">https://www.w3.org/TR/sparql11-overview/</a></dd>
<dt id="bib-turtle">[Turtle]</dt>
<dd><a href="https://www.w3.org/TR/turtle/" rel="cito:citesAsAuthority"><cite>RDF 1.1 Turtle</cite></a>. Eric Prud'hommeaux; Gavin Carothers. W3C. 25 February 2014. W3C Recommendation. URL: <a href="https://www.w3.org/TR/turtle/">https://www.w3.org/TR/turtle/</a></dd>
<dt id="bib-w3c-html">[W3C-HTML]</dt>
Expand Down