Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeIndex shapes #5

Merged
merged 15 commits into from
Feb 11, 2023
Merged

typeIndex shapes #5

merged 15 commits into from
Feb 11, 2023

Conversation

timea-solid
Copy link
Member

@timea-solid timea-solid commented Jan 10, 2023

For SHACL and ShEX

Copy link

@woutermont woutermont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Overal structure looks good to me. I've added some corrections and suggestions on the ShaCL/ShEx syntax.

shapes/typeIndex.shex Outdated Show resolved Hide resolved
shapes/typeIndex.shex Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
timea-solid and others added 7 commits January 14, 2023 19:53
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
@timea-solid
Copy link
Member Author

@woutermont thank you so much for the feedback thus far!
Let me know about the open question above and then I will go in and fix the rest to streamline the file.
Afterward, I will check in the meeting if the constraints are enough and correct.

timea-solid and others added 2 commits January 16, 2023 19:54
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Copy link

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good ^_^ Added some notes that I think should be resolved

shapes/typeIndex.shex Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shacl Outdated Show resolved Hide resolved
@woutermont
Copy link

woutermont commented Jan 17, 2023

EDIT: As discussed in the meeting, I've moved this to a separate issue #8


One general comment I have about TypeIndexes, and how they are used, is that we currently rely on the unspecified anti-LinkedData convention that Type Registrations will be served in the same file as the Type Index itself.

I.m.o. it would be better to specify this in a Linked Data manner, by adding an extra predicate to the Type Index shapes:

:TypeIndexShape a sh:NodeShape ;
    # ...
    sh:property [
        sh:path solid:hasTypeRegistration ;
        sh:nodeKind sh:IRI
    ] .
typeIndex:TypeIndex EXTRA a {
    # ...
    solid:hasTypeRegistration IRI .
}

This way, all Type Registrations are linked to from their Type Index.

timea-solid and others added 2 commits January 17, 2023 15:02
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
@timbl
Copy link
Contributor

timbl commented Jan 20, 2023

Maybe have separate alternative paths for instance and instanceContainer and set the target class (range) of instanceContainer to be ldp:Container

shapes/typeIndex.shacl Outdated Show resolved Hide resolved
shapes/typeIndex.shex Outdated Show resolved Hide resolved
timea-solid and others added 3 commits January 21, 2023 16:02
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
@timea-solid timea-solid merged commit 61c3907 into main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants