-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typeIndex shapes #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! Overal structure looks good to me. I've added some corrections and suggestions on the ShaCL/ShEx syntax.
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
@woutermont thank you so much for the feedback thus far! |
Co-authored-by: Wouter Termont <woutermont@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good ^_^ Added some notes that I think should be resolved
EDIT: As discussed in the meeting, I've moved this to a separate issue #8 One general comment I have about TypeIndexes, and how they are used, is that we currently rely on the unspecified anti-LinkedData convention that Type Registrations will be served in the same file as the Type Index itself. I.m.o. it would be better to specify this in a Linked Data manner, by adding an extra predicate to the Type Index shapes:
This way, all Type Registrations are linked to from their Type Index. |
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Maybe have separate alternative paths for |
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
For SHACL and ShEX