Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Handlebars version #2

Closed
solidgoldpig opened this issue Apr 4, 2015 · 1 comment
Closed

Upgrade Handlebars version #2

solidgoldpig opened this issue Apr 4, 2015 · 1 comment

Comments

@solidgoldpig
Copy link
Owner

Bauplan currently uses Handlebars 1.3.0.

However the version of Thorax prevents Handlebars being upgraded

First, bauplan.init must explicitly assign windows.Handlebars but even so Thorax occasionally triggers

"Uncaught TypeError: Cannot read property 'find' of undefined"
line 74 (unminified version)
@solidgoldpig
Copy link
Owner Author

This is now more pressing considering handlebars-lang/handlebars.js#1083

(As detailed in https://blog.srcclr.com/handlebars_vulnerability_research_findings/ and reported to me directly by @VanessaHenderson)

solidgoldpig added a commit that referenced this issue Jan 9, 2016
@solidgoldpig
Fix for #2
3199d88 
- Updated Handlebars
- Updated other core dependencies and removed unnecessary library files
- Caught edge case where nested control views do not have $el
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solidgoldpig