-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 🐛 Contradicting argument configurations #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better. Thank you! Could you also update the usage
section of the README to reflect the new arguments? I can update this part of the readme later once this is merged.
This removes the Clippy lint "struct_excessive_bool" from the "allow" list, reactivating it
The struct still contains more than 3 bools giving a big warning.
Alright, I think I've done it. Have I missed a section or anything? |
I would suggest "auto" instead of "colored". Maybe also add a long alias |
Indeed. This would probably be better. I'll change it right away! |
Right now, there are the following output coloring options:
and
This allows Users to contradict themselves when passing arguments like this:
Which is why I've come with the following solution:
and
This also allows Users to specify the coloring output they want with “-C” alone, making it more intuitive.