Enable type generation #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert this commit when following TypeScript issue is fixed: microsoft/TypeScript#42873
It serves the same purpose but correctly generates types.
Tested that dependency types can be resolved in another project, even when warning in dist folder.
|
@nix6839 Sorry this took so long to test out, but it's published in v0.13.2! Please let me know if there's any type-related issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a TypeScript compiler bug, not importing unused types causes a type generation error, so I added commit 8ccc56e.
Revert 8ccc56e when following TypeScript issue mentioned in the commit message is fixed.
Fix #128