Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies #130

Merged
merged 8 commits into from
Apr 13, 2024

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Mar 11, 2024

Summary

  • Replace fs-extra to node built-in fs/promises
  • Remove unused dependencies
  • Upgrade dependencies as much as possible
  • Turn off deprecated eslint rules to pass tests.

Dependencies that cannot be upgraded to the latest version:

  • husky: Dropped support for Node 14 and 16 in v9.
  • lint-staged: Drop support for Node.js 14 in v14 and Require at least Node.js 18.12.0 in v15.
  • rollup: The minimal required Node version is now 18.0.0 in v4.
  • @typescript-eslint/*: Node.js engine requirement to ^18.18.0 || >=20.0.0 and ESLint peer dependency requirement to ^8.56.0 in v7.
  • prettier: Changed to be async-based in v3, making it incompatible with markdown-magic.
  • is-html: This package is now pure ESM in v3.

Solutions for dependencies that cannot be upgraded to the latest version

This solutions includes breaking changes, so would like to hear your opinion @joshwilsonvu.

  • @typescript-eslint/*, husky, lint-staged, rollup: Change the supported Node.js version to ^18.18.0 || >=20.0.0.
  • @typescript-eslint/*: Change the supported ESLint version to ^8.56.0.
  • prettier: Replace markdown-magic or use @prettier/sync
  • is-html: It is only possible when we drop support for legacy configs in the future.

P.S. ESLint v9 has been released. IMO, it's a good time to drop support for versions below ESLint v8.57.0!

@nix6839 nix6839 force-pushed the cleanup-dependencies branch from d44779f to 7197864 Compare March 20, 2024 13:30
@nix6839 nix6839 force-pushed the cleanup-dependencies branch from 7197864 to 80bed2a Compare March 20, 2024 13:31
@nix6839 nix6839 force-pushed the cleanup-dependencies branch from 80bed2a to 54a2562 Compare April 4, 2024 04:04
@joshwilsonvu joshwilsonvu merged commit ce76fa0 into solidjs-community:main Apr 13, 2024
@nix6839 nix6839 deleted the cleanup-dependencies branch April 14, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants